ALSA: opl3: Hardening for potential Spectre v1
authorTakashi Iwai <tiwai@suse.de>
Tue, 24 Apr 2018 05:56:07 +0000 (07:56 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:38 +0000 (21:36 -0400)
commit780b273920078cfbc63143fc695fca1e37b6a176
treec069b923482ed3542c445e3cf2de75c5452b8160
parent59af19047988930ff1c6a0dbb42bbe84db7bf42f
ALSA: opl3: Hardening for potential Spectre v1

[ Upstream commit 7f054a5bee0987f1e2d4e59daea462421c76f2cb ]

As recently Smatch suggested, one place in OPL3 driver may expand the
array directly from the user-space value with speculation:
  sound/drivers/opl3/opl3_synth.c:476 snd_opl3_set_voice() warn: potential spectre issue 'snd_opl3_regmap'

This patch puts array_index_nospec() for hardening against it.

BugLink: https://marc.info/?l=linux-kernel&m=152411496503418&w=2
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/drivers/opl3/opl3_synth.c