[PATCH] limit request_fn recursion
authorJens Axboe <axboe@suse.de>
Thu, 11 May 2006 06:20:16 +0000 (08:20 +0200)
committerChris Wright <chrisw@sous-sol.org>
Sat, 20 May 2006 22:00:31 +0000 (15:00 -0700)
commit7984c7b5a2ccd821caeab3d751e0941ca5e8b8d1
tree8efd3960a7f1b6d1aad1353deb88ae2cbc5bc67f
parent0cf72aa68c30845d4ac076909af4edd6e4cdaab9
[PATCH] limit request_fn recursion

Don't recurse back into the driver even if the unplug threshold is met,
when the driver asks for a requeue. This is both silly from a logical
point of view (requeues typically happen due to driver/hardware
shortage), and also dangerous since we could hit an endless request_fn
-> requeue -> unplug -> request_fn loop and crash on stack overrun.

Also limit blk_run_queue() to one level of recursion, similar to how
blk_start_queue() works.

This patch fixed a real problem with SLES10 and lpfc, and it could hit
any SCSI lld that returns non-zero from it's ->queuecommand() handler.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
block/elevator.c
block/ll_rw_blk.c