signal: Properly deliver SIGSEGV from x86 uprobes
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 20 Jul 2018 01:48:30 +0000 (20:48 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Nov 2019 14:53:53 +0000 (15:53 +0100)
commit79b1b5ec76bb3ca7186e9c6886b81399d573acf2
tree2f6000de8788f4039e658e14ccefc6457f8d998e
parentdc9c09f5edc5aeaa1e04bc63b15c56b81bb6ee92
signal: Properly deliver SIGSEGV from x86 uprobes

[ Upstream commit 4a63c1ffd384ebdce40aac9c997dab68379137be ]

For userspace to tell the difference between an random signal
and an exception, the exception must include siginfo information.

Using SEND_SIG_FORCED for SIGSEGV is thus wrong, and it will result in
userspace seeing si_code == SI_USER (like a random signal) instead of
si_code == SI_KERNEL or a more specific si_code as all exceptions
deliver.

Therefore replace force_sig_info(SIGSEGV, SEND_SIG_FORCE, current)
with force_sig(SIG_SEGV, current) which gets this right and is shorter
and easier to type.

Fixes: 791eca10107f ("uretprobes/x86: Hijack return address")
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/kernel/uprobes.c