scsi: ufs: ufshpb: Fix a NULL check on list iterator
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Sun, 20 Mar 2022 15:07:33 +0000 (23:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Apr 2022 18:03:17 +0000 (20:03 +0200)
commit7a3767065a474ace9e86146657a98c6a47a48655
tree4026e43d8122afaf9f774697afe3143e5ed8d173
parent4a7c3e11ff9ca5977a6daf60a023839668e5dbe4
scsi: ufs: ufshpb: Fix a NULL check on list iterator

[ Upstream commit bfb7789bcbd901caead43861461bc8f334c90d3b ]

The list iterator is always non-NULL so the check 'if (!rgn)' is always
false and the dev_err() is never called. Move the check outside the loop
and determine if 'victim_rgn' is NULL, to fix this bug.

Link: https://lore.kernel.org/r/20220320150733.21824-1-xiam0nd.tong@gmail.com
Fixes: 4b5f49079c52 ("scsi: ufs: ufshpb: L2P map management for HPB read")
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/ufs/ufshpb.c