ASoC: cs42l42: Remove duplicate control for WNF filter frequency
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 3 Aug 2021 16:08:34 +0000 (17:08 +0100)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:37:01 +0000 (08:37 -0400)
commit7a4c268b6df0d3eb8c0c8bbcc9238beb452b327f
treecdfd25f2eded1882cb4f1a04a47dd0d3958cc0f7
parent75ce995fd897d544b017fa3410f18822626143de
ASoC: cs42l42: Remove duplicate control for WNF filter frequency

[ Upstream commit 8b353bbeae20e2214c9d9d88bcb2fda4ba145d83 ]

The driver was defining two ALSA controls that both change the same
register field for the wind noise filter corner frequency. The filter
response has two corners, at different frequencies, and the duplicate
controls most likely were an attempt to be able to set the value using
either of the frequencies.

However, having two controls changing the same field can be problematic
and it is unnecessary. Both frequencies are related to each other so
setting one implies exactly what the other would be.

Removing a control affects user-side code, but there is currently no
known use of the removed control so it would be best to remove it now
before it becomes a problem.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec")
Link: https://lore.kernel.org/r/20210803160834.9005-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/cs42l42.c