sctp: update the netstamp_needed counter when copying sockets
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Fri, 4 Dec 2015 17:14:04 +0000 (15:14 -0200)
committerWilly Tarreau <w@1wt.eu>
Fri, 29 Jan 2016 21:12:50 +0000 (22:12 +0100)
commit7e0e67b0bbd024c074cd9ac61c2a8f8ebb9be619
tree08429b754326df2f688c24115fec17211bc16993
parent224994fa6d46e7aba39b8bd1d4121dd949642848
sctp: update the netstamp_needed counter when copying sockets

[ Upstream commit 01ce63c90170283a9855d1db4fe81934dddce648 ]

Dmitry Vyukov reported that SCTP was triggering a WARN on socket destroy
related to disabling sock timestamp.

When SCTP accepts an association or peel one off, it copies sock flags
but forgot to call net_enable_timestamp() if a packet timestamping flag
was copied, leading to extra calls to net_disable_timestamp() whenever
such clones were closed.

The fix is to call net_enable_timestamp() whenever we copy a sock with
that flag on, like tcp does.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: SK_FLAGS_TIMESTAMP is newly defined]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit d85242d91610acbe4f905624a5758a01ae7bb32c)
Signed-off-by: Willy Tarreau <w@1wt.eu>
include/net/sock.h
net/sctp/socket.c