NFSv4 fix CLOSE not waiting for direct IO compeletion
authorOlga Kornievskaia <olga.kornievskaia@gmail.com>
Wed, 24 Jun 2020 17:54:08 +0000 (13:54 -0400)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:36:30 +0000 (15:36 -0400)
commit7f7f6661674f16f02cc7ac0a4a245a42cf8f52f1
treef2ef835e109fd863498b41bc0d694257419b40b9
parent0f1ce854d7cb2c8b4840449e5b1d63410c16d0aa
NFSv4 fix CLOSE not waiting for direct IO compeletion

commit d03727b248d0dae6199569a8d7b629a681154633 upstream.

Figuring out the root case for the REMOVE/CLOSE race and
suggesting the solution was done by Neil Brown.

Currently what happens is that direct IO calls hold a reference
on the open context which is decremented as an asynchronous task
in the nfs_direct_complete(). Before reference is decremented,
control is returned to the application which is free to close the
file. When close is being processed, it decrements its reference
on the open_context but since directIO still holds one, it doesn't
sent a close on the wire. It returns control to the application
which is free to do other operations. For instance, it can delete a
file. Direct IO is finally releasing its reference and triggering
an asynchronous close. Which races with the REMOVE. On the server,
REMOVE can be processed before the CLOSE, failing the REMOVE with
EACCES as the file is still opened.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Suggested-by: Neil Brown <neilb@suse.com>
CC: stable@vger.kernel.org
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/direct.c
fs/nfs/file.c