Initialize msg/shm IPC objects before doing ipc_addid()
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Sep 2015 16:48:40 +0000 (12:48 -0400)
committerWilly Tarreau <w@1wt.eu>
Sat, 5 Dec 2015 23:49:04 +0000 (00:49 +0100)
commit81ced12a27231240cfff9f8ebd6dd243b779d064
tree9d784a156d92c535128b01aefb4c3c584132dadd
parent424d5990e894ed0e580142ccc58b9d4e3dfdd334
Initialize msg/shm IPC objects before doing ipc_addid()

commit b9a532277938798b53178d5a66af6e2915cb27cf upstream.

As reported by Dmitry Vyukov, we really shouldn't do ipc_addid() before
having initialized the IPC object state.  Yes, we initialize the IPC
object in a locked state, but with all the lockless RCU lookup work,
that IPC object lock no longer means that the state cannot be seen.

We already did this for the IPC semaphore code (see commit e8577d1f0329:
"ipc/sem.c: fully initialize sem_array before making it visible") but we
clearly forgot about msg and shm.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 2.6.32:
 - Adjust context
 - The error path being moved looks a little different]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
ipc/msg.c
ipc/shm.c
ipc/util.c