sg_write()/bsg_write() is not fit to be called under KERNEL_DS
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 16 Dec 2016 18:42:06 +0000 (13:42 -0500)
committerWilly Tarreau <w@1wt.eu>
Tue, 20 Jun 2017 12:03:25 +0000 (14:03 +0200)
commit823a2a0330f25ccea8ef64ee4a378e37ca51361c
tree14a9c5683dd030f6f0eb496ace07aeb7246ba620
parentb1230ef86d56322ebc21b1dbd7fa91250ca5d266
sg_write()/bsg_write() is not fit to be called under KERNEL_DS

commit 128394eff343fc6d2f32172f03e24829539c5835 upstream.

Both damn things interpret userland pointers embedded into the payload;
worse, they are actually traversing those.  Leaving aside the bad
API design, this is very much _not_ safe to call with KERNEL_DS.
Bail out early if that happens.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
block/bsg.c
drivers/scsi/sg.c