net: fix rtnh_ok()
authorEric Dumazet <edumazet@google.com>
Sat, 7 Apr 2018 20:42:38 +0000 (13:42 -0700)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:40 +0000 (21:36 -0400)
commit8618149be8b741e5eeb56a4ae641e3a0a83297a7
tree3a5e6dc828e7d46e67d57da47c3c75350bb6ef11
parent84889429a9a075e4da15bf24911e06dcc2c3bb4f
net: fix rtnh_ok()

[ Upstream commit b1993a2de12c9e75c35729e2ffbc3a92d50c0d31 ]

syzbot reported :

BUG: KMSAN: uninit-value in rtnh_ok include/net/nexthop.h:11 [inline]
BUG: KMSAN: uninit-value in fib_count_nexthops net/ipv4/fib_semantics.c:469 [inline]
BUG: KMSAN: uninit-value in fib_create_info+0x554/0x8d20 net/ipv4/fib_semantics.c:1091

@remaining is an integer, coming from user space.
If it is negative we want rtnh_ok() to return false.

Fixes: 4e902c57417c ("[IPv4]: FIB configuration using struct fib_config")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
include/net/nexthop.h