dm thin metadata: check if in fail_io mode when setting needs_check
authorMike Snitzer <snitzer@redhat.com>
Tue, 2 Jul 2019 19:50:08 +0000 (15:50 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:11:11 +0000 (09:11 +0200)
commit8e4c803e7f5fdd611b0b9e887f40a2bd191dc26f
tree560da2240a6fa9efa15c7ae1ed17dd35675b8aea
parent71e19cde733daa870f22d47791378735e4f6cab2
dm thin metadata: check if in fail_io mode when setting needs_check

commit 54fa16ee532705985e6c946da455856f18f63ee1 upstream.

Check if in fail_io mode at start of dm_pool_metadata_set_needs_check().
Otherwise dm_pool_metadata_set_needs_check()'s superblock_lock() can
crash in dm_bm_write_lock() while accessing the block manager object
that was previously destroyed as part of a failed
dm_pool_abort_metadata() that ultimately set fail_io to begin with.

Also, update DMERR() message to more accurately describe
superblock_lock() failure.

Cc: stable@vger.kernel.org
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-thin-metadata.c