tracing/filter: Do not WARN on operand count going below zero
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Thu, 25 Jun 2015 22:02:29 +0000 (18:02 -0400)
committerWilly Tarreau <w@1wt.eu>
Fri, 18 Sep 2015 11:52:14 +0000 (13:52 +0200)
commit8f2f643048d52d0d2eef33fd97f863840e8f0fb9
tree232d4e9d3bfe0b75de35134fedf2136e6d46b968
parente18af8563578c0d292bef9a3f3c0206242f742e5
tracing/filter: Do not WARN on operand count going below zero

commit b4875bbe7e68f139bd3383828ae8e994a0df6d28 upstream.

When testing the fix for the trace filter, I could not come up with
a scenario where the operand count goes below zero, so I added a
WARN_ON_ONCE(cnt < 0) to the logic. But there is legitimate case
that it can happen (although the filter would be wrong).

 # echo '>' > /sys/kernel/debug/events/ext4/ext4_truncate_exit/filter

That is, a single operation without any operands will hit the path
where the WARN_ON_ONCE() can trigger. Although this is harmless,
and the filter is reported as a error. But instead of spitting out
a warning to the kernel dmesg, just fail nicely and report it via
the proper channels.

Link: http://lkml.kernel.org/r/558C6082.90608@oracle.com
Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit b43dd35952747f563d0dec7aefb7570260f10353)

Signed-off-by: Willy Tarreau <w@1wt.eu>
kernel/trace/trace_events_filter.c