drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()
authorMurray McAllister <murray.mcallister@gmail.com>
Sat, 11 May 2019 06:01:37 +0000 (18:01 +1200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Jun 2019 06:18:24 +0000 (08:18 +0200)
commit8f6b0e59d2a072cb19841b13fd8acba993ba55b3
tree06f2b67c794c717120aa28dda3a36604fd23b3ae
parent6e0c7e73232f4c1e3a87aa9b2149717f92e2302c
drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()

commit bcd6aa7b6cbfd6f985f606c6f76046d782905820 upstream.

If SVGA_3D_CMD_DX_DEFINE_RENDERTARGET_VIEW is called with a surface
ID of SVGA3D_INVALID_ID, the srf struct will remain NULL after
vmw_cmd_res_check(), leading to a null pointer dereference in
vmw_view_add().

Cc: <stable@vger.kernel.org>
Fixes: d80efd5cb3de ("drm/vmwgfx: Initial DX support")
Signed-off-by: Murray McAllister <murray.mcallister@gmail.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c