padata: upgrade smp_mb__after_atomic to smp_mb in padata_do_serial
authorDaniel Jordan <daniel.m.jordan@oracle.com>
Mon, 8 Jun 2020 21:26:52 +0000 (17:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jul 2020 07:39:37 +0000 (09:39 +0200)
commit9088c4ec1ac3fd3edf0913cfb91b217dc9e1ce3a
tree58e83689cea22ed8e3e4062ee4c783e0bbfde636
parentd67dde02049e632ba58d3c44a164a74b6a737154
padata: upgrade smp_mb__after_atomic to smp_mb in padata_do_serial

commit e04ec0de61c1eb9693179093e83ab8ca68a30d08 upstream.

A 5.7 kernel hangs during a tcrypt test of padata that waits for an AEAD
request to finish.  This is only seen on large machines running many
concurrent requests.

The issue is that padata never serializes the request.  The removal of
the reorder_objects atomic missed that the memory barrier in
padata_do_serial() depends on it.

Upgrade the barrier from smp_mb__after_atomic to smp_mb to get correct
ordering again.

Fixes: 3facced7aeed1 ("padata: remove reorder_objects")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/padata.c