efi: Make efivarfs entries immutable by default
authorPeter Jones <pjones@redhat.com>
Mon, 8 Feb 2016 19:48:15 +0000 (14:48 -0500)
committerLuis Henriques <luis.henriques@canonical.com>
Thu, 24 Mar 2016 10:01:20 +0000 (10:01 +0000)
commita3c70636ed1ed48f874193bc397ee0087dad7c0a
tree1f22bc1571d1229862306e1f05266d8b578cc084
parent67217cf59d0aa23bb8bba12aae0dff65f23f26a5
efi: Make efivarfs entries immutable by default

commit ed8b0de5a33d2a2557dce7f9429dca8cb5bc5879 upstream.

"rm -rf" is bricking some peoples' laptops because of variables being
used to store non-reinitializable firmware driver data that's required
to POST the hardware.

These are 100% bugs, and they need to be fixed, but in the mean time it
shouldn't be easy to *accidentally* brick machines.

We have to have delete working, and picking which variables do and don't
work for deletion is quite intractable, so instead make everything
immutable by default (except for a whitelist), and make tools that
aren't quite so broad-spectrum unset the immutable flag.

Signed-off-by: Peter Jones <pjones@redhat.com>
Tested-by: Lee, Chun-Yi <jlee@suse.com>
Acked-by: Matthew Garrett <mjg59@coreos.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
[ luis: backported to 3.16:
  - use mutex_lock/unlock() instead of inode_lock/unlock()
  - use root->d_inode instead of d_inode()  ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Documentation/filesystems/efivarfs.txt
drivers/firmware/efi/vars.c
fs/efivarfs/file.c
fs/efivarfs/inode.c
fs/efivarfs/internal.h
fs/efivarfs/super.c
include/linux/efi.h
tools/testing/selftests/efivarfs/efivarfs.sh
tools/testing/selftests/efivarfs/open-unlink.c