bnx2x: Prevent load reordering in tx completion processing
authorBrian King <brking@linux.vnet.ibm.com>
Mon, 15 Jul 2019 21:41:50 +0000 (16:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Aug 2019 07:34:54 +0000 (09:34 +0200)
commita4af24423e5f75a2bcb1dec95365d89a78cf7c7a
tree2a6df476bf4ca7ef166f1523cee16c25858ac3f5
parent40f8aa133ba248742bec1d3f1e34286fef83f9f2
bnx2x: Prevent load reordering in tx completion processing

[ Upstream commit ea811b795df24644a8eb760b493c43fba4450677 ]

This patch fixes an issue seen on Power systems with bnx2x which results
in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c