random: Add comment to random_initialize()
authorTony Luck <tony.luck@intel.com>
Mon, 23 Jul 2012 16:47:57 +0000 (09:47 -0700)
committerWilly Tarreau <w@1wt.eu>
Sun, 7 Oct 2012 21:41:21 +0000 (23:41 +0200)
commita76be4858901fd9fd0fb8f594f660d1037cb03d8
tree1c3935f2918693dad3928b06c838a72f89e1a765
parentfe1f4c7d2602bda2dddb13fd34e9678514478e12
random: Add comment to random_initialize()

commit cbc96b7594b5691d61eba2db8b2ea723645be9ca upstream.

Many platforms have per-machine instance data (serial numbers,
asset tags, etc.) squirreled away in areas that are accessed
during early system bringup. Mixing this data into the random
pools has a very high value in providing better random data,
so we should allow (and even encourage) architecture code to
call add_device_randomness() from the setup_arch() paths.

However, this limits our options for internal structure of
the random driver since random_initialize() is not called
until long after setup_arch().

Add a big fat comment to rand_initialize() spelling out
this requirement.

Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/char/random.c