powerpc/powernv: Fix opal_exit tracepoint opcode
authorMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 Feb 2017 10:01:01 +0000 (21:01 +1100)
committerSasha Levin <alexander.levin@verizon.com>
Tue, 13 Jun 2017 13:29:19 +0000 (09:29 -0400)
commitab1b642339b38c8ddaceb65b03ec6bb589c82b7e
tree87cd4026bba716ebbfa2b193ea1362efd25b20dd
parent5d1767ceff1f67969265f497f6e8d7d21feb188e
powerpc/powernv: Fix opal_exit tracepoint opcode

[ Upstream commit a7e0fb6c2029a780444d09560f739e020d54fe4d ]

Currently the opal_exit tracepoint usually shows the opcode as 0:

  <idle>-0     [047] d.h.   635.654292: opal_entry: opcode=63
  <idle>-0     [047] d.h.   635.654296: opal_exit: opcode=0 retval=0
  kopald-1209  [019] d...   636.420943: opal_entry: opcode=10
  kopald-1209  [019] d...   636.420959: opal_exit: opcode=0 retval=0

This is because we incorrectly load the opcode into r0 before calling
__trace_opal_exit(), whereas it expects the opcode in r3 (first function
parameter). In fact we are leaving the retval in r3, so opcode and
retval will always show the same value.

Instead load the opcode into r3, resulting in:

  <idle>-0     [040] d.h.   636.618625: opal_entry: opcode=63
  <idle>-0     [040] d.h.   636.618627: opal_exit: opcode=63 retval=0

Fixes: c49f63530bb6 ("powernv: Add OPAL tracepoints")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
arch/powerpc/platforms/powernv/opal-wrappers.S