SMB3.1.1: do not log warning message if server doesn't populate salt
authorSteve French <stfrench@microsoft.com>
Thu, 10 Dec 2020 04:19:00 +0000 (22:19 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Jan 2021 12:54:10 +0000 (13:54 +0100)
commitab85b382dcf7ba13d29d1693622c7ed8bfa4e98c
tree269a04f78e5aa9dee9cae635a3a553db0c9f69f2
parent0edc78af73d054d01dc14d7344024362811d8bd3
SMB3.1.1: do not log warning message if server doesn't populate salt

commit 7955f105afb6034af344038d663bc98809483cdd upstream.

In the negotiate protocol preauth context, the server is not required
to populate the salt (although it is done by most servers) so do
not warn on mount.

We retain the checks (warn) that the preauth context is the minimum
size and that the salt does not exceed DataLength of the SMB response.
Although we use the defaults in the case that the preauth context
response is invalid, these checks may be useful in the future
as servers add support for additional mechanisms.

CC: Stable <stable@vger.kernel.org>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2pdu.c
fs/cifs/smb2pdu.h