bootconfig: Fix missing return check of xbc_node_compose_key function
authorJulio Faracco <jcfaracco@gmail.com>
Sat, 4 Sep 2021 15:54:38 +0000 (00:54 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 08:02:36 +0000 (10:02 +0200)
commitac16137d64bb0844b22ea90967bfc54360683be8
tree75a12aa680e6cb799c603f4fa55ce074c4c43513
parentfbc0d19393cbf49c28f538b7fdd94f92655f7870
bootconfig: Fix missing return check of xbc_node_compose_key function

commit 903bd067faa837fddb6e5c8b740c3374dc582f04 upstream.

The function `xbc_show_list should` handle the keys during the
composition. Even the errors returned by the compose function. Instead
of removing the `ret` variable, it should save the value and show the
exact error. This missing variable is causing a compilation issue also.

Link: https://lkml.kernel.org/r/163077087861.222577.12884543474750968146.stgit@devnote2
Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key")
Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/bootconfig/main.c