usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 17 Nov 2017 20:02:09 +0000 (14:02 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 May 2019 07:15:17 +0000 (09:15 +0200)
commitb41449d9be2103c15c22b988d10b6303fdadebd3
tree5ebe7750276a6760c30277dceb32f0d145c77593
parentf5bca75dc46701f4c0d1dcbaae401233ae7ff06b
usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set

commit 61c59355e0154a938b28710dfa6c1d8be2ddcefa upstream.

_dev_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference.

Fix this by moving the pointer dereference after _dev_ has been null
checked.

Addresses-Coverity-ID: 1462020
Fixes: bb1b40c7cb86 ("usbnet: ipheth: prevent TX queue timeouts when device not ready")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/ipheth.c