scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND
authorJan Kara <jack@suse.cz>
Thu, 23 Oct 2014 02:13:39 +0000 (20:13 -0600)
committerWilly Tarreau <w@1wt.eu>
Sun, 24 May 2015 08:10:54 +0000 (10:10 +0200)
commitb5f10e98858103faed1c39cb5f5404d2d3ce58a2
treea2187727e6a8387cc96a5e572ef76479bf53c353
parenta3ea94483f8561c06464bed39d2d5b854ae3b5f5
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.

When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just end up copying
(luckily zeroed-out) kernel buffer to userspace instead of reporting
error. Fix the problem by jumping to the right label.

CC: Jens Axboe <axboe@kernel.dk>
CC: linux-scsi@vger.kernel.org
Coverity-id: 1226871
Signed-off-by: Jan Kara <jack@suse.cz>
Fixed up the, now unused, out label.

Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit d73b032b63e8967462e1cf5763858ed89e97880f)

Signed-off-by: Willy Tarreau <w@1wt.eu>
block/scsi_ioctl.c