bpf: Fix preempt_enable_no_resched() abuse
authorPeter Zijlstra <peterz@infradead.org>
Tue, 23 Apr 2019 19:55:59 +0000 (21:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 May 2019 16:22:28 +0000 (18:22 +0200)
commitbd61ddd3e9fc45a9c7d8852827fec9f3693d278d
treeb62dbe8b48d9207ec5f64cad346d42c95ddf04e8
parentbd3713424a01a3ceb684a354363d5239eec1e9ee
bpf: Fix preempt_enable_no_resched() abuse

[ Upstream commit 0edd6b64d1939e9e9168ff27947995bb7751db5d ]

Unless the very next line is schedule(), or implies it, one must not use
preempt_enable_no_resched(). It can cause a preemption to go missing and
thereby cause arbitrary delays, breaking the PREEMPT=y invariant.

Cc: Roman Gushchin <guro@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/bpf.h