phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211
authorAl Cooper <alcooperx@gmail.com>
Fri, 2 Oct 2020 19:01:15 +0000 (15:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Dec 2020 09:58:29 +0000 (10:58 +0100)
commitbe9a0b6883fa6d37563c401732309382da5caa15
treeb919abe063fb6a69a4a3797d7016b4d1ffb510a7
parentdd81cf1cd50021b8dd65ae0cef0ec80c86b11d3e
phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211

[ Upstream commit 209c805835b29495cf66cc705b206da8f4a68e6e ]

The 7211a0 has a tca_drv_sel bit in the USB SETUP register that
should never be enabled. This feature is only used if there is a
USB Type-C PHY, and the 7211 does not have one. If the bit is
enabled, the VBUS signal will never be asserted. In the 7211a0,
the bit was incorrectly defaulted to on so the driver had to clear
the bit. In the 7211c0 the state was inverted so the driver should
no longer clear the bit. This hasn't been a problem because all
current 7211 boards don't use the VBUS signal, but there are some
future customer boards that may use it.

Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201002190115.48017-1-alcooperx@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c