usbnet: do not pretend to support SG/TSO
authorEric Dumazet <edumazet@google.com>
Wed, 24 Jul 2013 00:15:54 +0000 (17:15 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Sep 2013 00:57:06 +0000 (01:57 +0100)
commitbebbaccfb5aca61648dfeb8cfa25ce3293bc8ddb
tree855e967764ab41564e81c171aa85cf7225a5f137
parent0d7524ff0c62ea63b6a4b65173e67ef8eeefb402
usbnet: do not pretend to support SG/TSO

[ Upstream commit 20f0170377264e8449b6987041f0bcc4d746d3ed ]

usbnet doesn't support yet SG, so drivers should not advertise SG or TSO
capabilities, as they allow TCP stack to build large TSO packets that
need to be linearized and might use order-5 pages.

This adds an extra copy overhead and possible allocation failures.

Current code ignore skb_linearize() return code so crashes are even
possible.

Best is to not pretend SG/TSO is supported, and add this again when/if
usbnet really supports SG for devices who could get a performance gain.

Based on a prior patch from Freddy Xin <freddy@asix.com.tw>

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/usb/smsc75xx.c