crypto: x86/chacha20 - Avoid spurious jumps to other functions
authorPeter Zijlstra <peterz@infradead.org>
Tue, 22 Mar 2022 11:48:10 +0000 (12:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 May 2022 07:14:32 +0000 (09:14 +0200)
commitc0d86f2a3c031222f625d6264307a35bf09ea874
tree0390a646132fb683346a4f2710feee24939b4ae3
parentf0213894337afa0b5367ea11c6879c27ece556c7
crypto: x86/chacha20 - Avoid spurious jumps to other functions

[ Upstream commit 4327d168515fd8b5b92fa1efdf1d219fb6514460 ]

The chacha_Nblock_xor_avx512vl() functions all have their own,
identical, .LdoneN label, however in one particular spot {2,4} jump to
the 8 version instead of their own. Resulting in:

  arch/x86/crypto/chacha-x86_64.o: warning: objtool: chacha_2block_xor_avx512vl() falls through to next function chacha_8block_xor_avx512vl()
  arch/x86/crypto/chacha-x86_64.o: warning: objtool: chacha_4block_xor_avx512vl() falls through to next function chacha_8block_xor_avx512vl()

Make each function consistently use its own done label.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/crypto/chacha-avx512vl-x86_64.S