KVM: x86: Disallow hypercalls for guest callers in rings > 0 [CVE-2009-3290]
authorJan Kiszka <jan.kiszka@siemens.com>
Wed, 7 Oct 2009 21:40:32 +0000 (17:40 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 12 Oct 2009 18:33:20 +0000 (11:33 -0700)
commitc905930150d0952c4ce008553b377492bcbd29d7
tree91fde9a15252018b163295da2e1eb3886b1043a4
parent2578cf95969936c372db29ee2bbc21c9b6a299aa
KVM: x86: Disallow hypercalls for guest callers in rings > 0 [CVE-2009-3290]

[ backport to 2.6.27 by Chuck Ebbert <cebbert@redhat.com> ]

commit 07708c4af1346ab1521b26a202f438366b7bcffd upstream.

So far unprivileged guest callers running in ring 3 can issue, e.g., MMU
hypercalls. Normally, such callers cannot provide any hand-crafted MMU
command structure as it has to be passed by its physical address, but
they can still crash the guest kernel by passing random addresses.

To close the hole, this patch considers hypercalls valid only if issued
from guest ring 0. This may still be relaxed on a per-hypercall base in
the future once required.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kvm/x86.c
include/linux/kvm_para.h