lightnvm: fix uninitialized pointer in nvm_remove_tgt()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 21 Jun 2019 09:12:00 +0000 (11:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:10:31 +0000 (09:10 +0200)
commitcf1d95daf12cb83eaf57044e55a5ab8d82da9535
treed40ae9baa2aaed9aba750106aef5889bce51910c
parentc8a410cd3cfba1aabae6bfd4a38d395c4ebd9df6
lightnvm: fix uninitialized pointer in nvm_remove_tgt()

[ Upstream commit 2f5af4ab7de14bd35f3435e6a47300276bbb6c17 ]

With gcc 4.1:

    drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’:
    drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function

Indeed, if no NVM devices have been registered, t will be an
uninitialized pointer, and may be dereferenced later.  A call to
nvm_remove_tgt() can be triggered from userspace by issuing the
NVM_DEV_REMOVE ioctl on the lightnvm control device.

Fix this by preinitializing t to NULL.

Fixes: 843f2edbdde085b4 ("lightnvm: do not remove instance under global lock")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/lightnvm/core.c