exportfs: do not read dentry after free
authorPan Bian <bianpan2016@163.com>
Fri, 23 Nov 2018 07:56:33 +0000 (15:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 20:55:10 +0000 (21:55 +0100)
commitd4327131dbe0147d0f07c5f0a65a0cb079bd2caa
tree815158f2d2b3f0a4c42115fbdb39947777c37935
parent476bea0f653c47228d22975a16858a080de04993
exportfs: do not read dentry after free

[ Upstream commit 2084ac6c505a58f7efdec13eba633c6aaa085ca5 ]

The function dentry_connected calls dput(dentry) to drop the previously
acquired reference to dentry. In this case, dentry can be released.
After that, IS_ROOT(dentry) checks the condition
(dentry == dentry->d_parent), which may result in a use-after-free bug.
This patch directly compares dentry with its parent obtained before
dropping the reference.

Fixes: a056cc8934c("exportfs: stop retrying once we race with
rename/remove")

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/exportfs/expfs.c