TTY: drop driver reference in tty_open fail path
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:42 +0000 (11:32 +0200)
committerWilly Tarreau <w@1wt.eu>
Fri, 18 Sep 2015 11:51:52 +0000 (13:51 +0200)
commitd447af56f50bdcb4d5ca378ed6b2d48fb0b973ac
tree3dcef307d6de5c9c0485f0a030170a75c5b32f55
parent435f34cb44936431d6b2d8525ba6beab2a9e6b03
TTY: drop driver reference in tty_open fail path

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[bwh: Backported to 2.6.32: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
CVE-2011-5321

Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/char/tty_io.c