ses: fix additional element traversal bug
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 11 Dec 2015 17:16:38 +0000 (09:16 -0800)
committerWilly Tarreau <w@1wt.eu>
Fri, 29 Jan 2016 21:12:52 +0000 (22:12 +0100)
commitd4b6a10d1fc87c0078f6d9b107d91029bff6cc8a
tree3bccc0739e7c79ea09d2331557fdc7547dbf480c
parentf49fbe9ebc13e57ba5b2d91a1c1ffe0b4edf0cb1
ses: fix additional element traversal bug

commit 5e1033561da1152c57b97ee84371dba2b3d64c25 upstream.

KASAN found that our additional element processing scripts drop off
the end of the VPD page into unallocated space.  The reason is that
not every element has additional information but our traversal
routines think they do, leading to them expecting far more additional
information than is present.  Fix this by adding a gate to the
traversal routine so that it only processes elements that are expected
to have additional information (list is in SES-2 section 6.1.13.1:
Additional Element Status diagnostic page overview)

Reported-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Tested-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit 344d6d02690a650607e6372bce8fe40e647a51b5)
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/scsi/ses.c
include/linux/enclosure.h