SUNRPC: Prevent an rpc_task wakeup race
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 22 May 2013 16:57:24 +0000 (12:57 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Mar 2014 23:10:08 +0000 (16:10 -0700)
commitd4d811d55f75e02ae7beaea3dc611498bf2bf5fb
treee4c33ce76c4b650716915c57546a17591709c521
parente8d5ce17375e2ece50659f287ad1a3daf2335d7e
SUNRPC: Prevent an rpc_task wakeup race

commit a3c3cac5d31879cd9ae2de7874dc6544ca704aec upstream.

The lockless RPC_IS_QUEUED() test in __rpc_execute means that we need to
be careful about ordering the calls to rpc_test_and_set_running(task) and
rpc_clear_queued(task). If we get the order wrong, then we may end up
testing the RPC_TASK_RUNNING flag after __rpc_execute() has looped
and changed the state of the rpc_task.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Weng Meiling <wengmeiling.weng@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/sched.c