ACPI/AC: prevent OOPS on some boxes due to missing check power_supply_register()...
authorLan Tianyu <tianyu.lan@intel.com>
Fri, 20 Jul 2012 05:29:16 +0000 (13:29 +0800)
committerWilly Tarreau <w@1wt.eu>
Sun, 7 Oct 2012 21:38:06 +0000 (23:38 +0200)
commitd4e89205393edf4296d2345143b73ebfe17a7531
tree7d8e670e3ef13ecc1f3ede6c2953e154e7a5677d
parente59164b84573bc0ac55f000ffe678c4e7d22c68b
ACPI/AC: prevent OOPS on some boxes due to missing check power_supply_register() return value check

commit f197ac13f6eeb351b31250b9ab7d0da17434ea36 upstream.

In the ac.c, power_supply_register()'s return value is not checked.

As a result, the driver's add() ops may return success
even though the device failed to initialize.

For example, some BIOS may describe two ACADs in the same DSDT.
The second ACAD device will fail to register,
but ACPI driver's add() ops returns sucessfully.
The ACPI device will receive ACPI notification and cause OOPS.

https://bugzilla.redhat.com/show_bug.cgi?id=772730

Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/acpi/ac.c