dm btree: fix bufio buffer leaks in dm_btree_del() error path
authorJoe Thornber <ejt@redhat.com>
Thu, 10 Dec 2015 14:37:53 +0000 (14:37 +0000)
committerZefan Li <lizefan@huawei.com>
Wed, 26 Oct 2016 15:15:36 +0000 (23:15 +0800)
commitd8e33a2789a888f62f1ee2a0289509947c77bc65
tree350307be57a6981e3d92d5d8d72b0c70be3cc7d7
parent322d37f032a4d06408af44919ad969b02543afd0
dm btree: fix bufio buffer leaks in dm_btree_del() error path

commit ed8b45a3679eb49069b094c0711b30833f27c734 upstream.

If dm_btree_del()'s call to push_frame() fails, e.g. due to
btree_node_validator finding invalid metadata, the dm_btree_del() error
path must unlock all frames (which have active dm-bufio buffers) that
were pushed onto the del_stack.

Otherwise, dm_bufio_client_destroy() will BUG_ON() because dm-bufio
buffers have leaked, e.g.:
  device-mapper: bufio: leaked buffer 3, hold count 1, list 0

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/md/persistent-data/dm-btree.c