IB/core: Fix deadlock on uverbs modify_qp error flow
authorMoshe Lazer <moshel@mellanox.com>
Thu, 5 Feb 2015 11:53:52 +0000 (13:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Mar 2015 13:11:06 +0000 (14:11 +0100)
commitdb2b084cd0e1fd7f98b0b82965b2d6581bc79e02
treec5bb59165087aa54aa48bfc06de447704875b81a
parentd524fcea1f1bef297cae09a9d8bde4f60ed0c61e
IB/core: Fix deadlock on uverbs modify_qp error flow

commit 0fb8bcf022f19a375d7c4bd79ac513da8ae6d78b upstream.

The deadlock occurs in __uverbs_modify_qp: we take a lock (idr_read_qp)
and in case of failure in ib_resolve_eth_l2_attrs we don't release
it (put_qp_read).  Fix that.

Fixes: ed4c54e5b4ba ("IB/core: Resolve Ethernet L2 addresses when modifying QP")
Signed-off-by: Moshe Lazer <moshel@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/infiniband/core/uverbs_cmd.c