tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes
authorDavid Christensen <drc@linux.vnet.ibm.com>
Wed, 17 Jun 2020 18:51:17 +0000 (11:51 -0700)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:35:48 +0000 (15:35 -0400)
commitdbda438186daa07c36bed4ee4ce57a753eb0e7f8
tree6db8fa9153a79d4fb443f061d0ca1dd7d46c3024
parentbf780119617797b5690e999e59a64ad79a572374
tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

[ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ]

The driver function tg3_io_error_detected() calls napi_disable twice,
without an intervening napi_enable, when the number of EEH errors exceeds
eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.

Add check for pcierr_recovery which skips code already executed for the
"Frozen" state.

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/tg3.c