inet: fix addr_len/msg->msg_namelen assignment in recv_error and rxpmtu functions
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Fri, 22 Nov 2013 23:46:12 +0000 (00:46 +0100)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:54:01 +0000 (07:54 +0200)
commitdbf387a6491bf25a7aac8c17540376bff2a8a686
treee08872d66958fee986999241daa0a7bb70f8e3fb
parentb52a430ce161044be5e8c77a0e3275cc548e2558
inet: fix addr_len/msg->msg_namelen assignment in recv_error and rxpmtu functions

[ Upstream commit 85fbaa75037d0b6b786ff18658ddf0b4014ce2a4 ]

Commit bceaa90240b6019ed73b49965eac7d167610be69 ("inet: prevent leakage
of uninitialized memory to user in recv syscalls") conditionally updated
addr_len if the msg_name is written to. The recv_error and rxpmtu
functions relied on the recvmsg functions to set up addr_len before.

As this does not happen any more we have to pass addr_len to those
functions as well and set it to the size of the corresponding sockaddr
length.

This broke traceroute and such.

Fixes: bceaa90240b6 ("inet: prevent leakage of uninitialized memory to user in recv syscalls")
Reported-by: Brad Spengler <spender@grsecurity.net>
Reported-by: Tom Labanowski
Cc: mpb <mpb.mail@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
include/net/ip.h
include/net/ipv6.h
net/ipv4/ip_sockglue.c
net/ipv4/raw.c
net/ipv4/udp.c
net/ipv6/datagram.c
net/ipv6/raw.c
net/ipv6/udp.c