fs/pipe.c: return error code rather than 0 in pipe_write()
authorEric Biggers <ebiggers3@gmail.com>
Sat, 17 Oct 2015 21:26:09 +0000 (16:26 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Feb 2016 22:28:38 +0000 (14:28 -0800)
commitdc0f7c58ecaff61e587153a0a6bc4884846f1e8b
tree489c4f59e1b55129d1dd26572a819a8146ee9cb6
parentd5c7bab6f3b5dfd8a656dfc17ca5fec770118e6b
fs/pipe.c: return error code rather than 0 in pipe_write()

commit 6ae08069939f17422835448acae76bda8d96b16a upstream.

pipe_write() would return 0 if it failed to merge the beginning of the
data to write with the last, partially filled pipe buffer.  It should
return an error code instead.  Userspace programs could be confused by
write() returning 0 when called with a nonzero 'count'.

The EFAULT error case was a regression from f0d1bec9d5 ("new helper:
copy_page_from_iter()"), while the ops->confirm() error case was a much
older bug.

Test program:

#include <assert.h>
#include <errno.h>
#include <unistd.h>

int main(void)
{
int fd[2];
char data[1] = {0};

assert(0 == pipe(fd));
assert(1 == write(fd[1], data, 1));

/* prior to this patch, write() returned 0 here  */
assert(-1 == write(fd[1], NULL, 1));
assert(errno == EFAULT);
}

Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/pipe.c