tcp: fix cwnd undo on DSACK in F-RTO
authorYuchung Cheng <ycheng@google.com>
Fri, 30 May 2014 22:25:59 +0000 (15:25 -0700)
committerJiri Slaby <jslaby@suse.cz>
Mon, 23 Jun 2014 08:28:00 +0000 (10:28 +0200)
commitdc4d3702659539dc9bdebf3bb4cfd4187c1cc9c5
tree6f03dee41a7e65d95becd9d3288174a76579ff32
parent14bf635b2a49a67862fbc3ea2db76a5cef3a8bba
tcp: fix cwnd undo on DSACK in F-RTO

[ Upstream commit 0cfa5c07d6d1d7f8e710fc671c5ba1ce85e09fa4 ]

This bug is discovered by an recent F-RTO issue on tcpm list
https://www.ietf.org/mail-archive/web/tcpm/current/msg08794.html

The bug is that currently F-RTO does not use DSACK to undo cwnd in
certain cases: upon receiving an ACK after the RTO retransmission in
F-RTO, and the ACK has DSACK indicating the retransmission is spurious,
the sender only calls tcp_try_undo_loss() if some never retransmisted
data is sacked (FLAG_ORIG_DATA_SACKED).

The correct behavior is to unconditionally call tcp_try_undo_loss so
the DSACK information is used properly to undo the cwnd reduction.

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/ipv4/tcp_input.c