file caps: always start with clear bprm->caps_*
authorSerge Hallyn <serue@us.ibm.com>
Thu, 30 Oct 2008 16:52:23 +0000 (11:52 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Nov 2008 03:05:55 +0000 (19:05 -0800)
commitdcc5bc3d9f306cbb5e2f55d65bce1c8372b25fde
treef626e72642fae80aa0a1fc952f3220d5a5e80fe8
parentc17c98e2755a57e09f16432654f40027780cbacd
file caps: always start with clear bprm->caps_*

commit 3318a386e4ca68c76e0294363d29bdc46fcad670 upstream

While Linux doesn't honor setuid on scripts.  However, it mistakenly
behaves differently for file capabilities.

This patch fixes that behavior by making sure that get_file_caps()
begins with empty bprm->caps_*.  That way when a script is loaded,
its bprm->caps_* may be filled when binfmt_misc calls prepare_binprm(),
but they will be cleared again when binfmt_elf calls prepare_binprm()
next to read the interpreter's file capabilities.

Signed-off-by: Serge Hallyn <serue@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
Acked-by: Andrew G. Morgan <morgan@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
security/commoncap.c