module: remove over-zealous check in __module_get()
authorRusty Russell <rusty@rustcorp.com.au>
Sat, 7 Feb 2009 07:45:56 +0000 (18:15 +1030)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 12 Feb 2009 17:50:26 +0000 (09:50 -0800)
commitdec125f42f7dcfa7d327d467485f4ea8ef8ab0df
tree4e2e3266e33f3537ecceff6de020d687eb80ab77
parent7590496e9c5ad30e25359aba1b1cc32ddbadd834
module: remove over-zealous check in __module_get()

commit 7f9a50a5b89b87f8e754f59ae9968da28be618a5 upstream.

Impact: fix spurious BUG_ON() triggered under load

module_refcount() isn't reliable outside stop_machine(), as demonstrated
by Karsten Keil <kkeil@suse.de>, networking can trigger it under load
(an inc on one cpu and dec on another while module_refcount() is tallying
 can give false results, for example).

Almost noone should be using __module_get, but that's another issue.

Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/module.h