tracing: Fix memory leak in set_trigger_filter()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 10 Dec 2018 02:17:30 +0000 (21:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Dec 2018 13:08:47 +0000 (14:08 +0100)
commite0b24233eaef5b0df59fdbf21a34c4ccfb93fa3a
tree5aa6b6a1b6a45e5b5e423d74f9cfde5c6df45fe6
parent0fe2a841cc81dbb1e743b75fdd7d03f1c928bc9a
tracing: Fix memory leak in set_trigger_filter()

commit 3cec638b3d793b7cacdec5b8072364b41caeb0e1 upstream.

When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/trace_events_trigger.c