net/smc: Fix sock leak when release after smc_shutdown()
authorTony Lu <tonylu@linux.alibaba.com>
Thu, 14 Apr 2022 07:51:03 +0000 (15:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Apr 2022 11:50:46 +0000 (13:50 +0200)
commite1bc684c81f1b9f935d2c4f3a760823cd6ba824b
tree20e07e3567bf9f4af8188cb78ac8b3734eafd9fa
parentf10e5c9f226cf90fcf796e590b75dea85d3bdfd8
net/smc: Fix sock leak when release after smc_shutdown()

[ Upstream commit 1a74e99323746353bba11562a2f2d0aa8102f402 ]

Since commit e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown
and fallback"), for a fallback connection, __smc_release() does not call
sock_put() if its state is already SMC_CLOSED.

When calling smc_shutdown() after falling back, its state is set to
SMC_CLOSED but does not call sock_put(), so this patch calls it.

Reported-and-tested-by: syzbot+6e29a053eb165bd50de5@syzkaller.appspotmail.com
Fixes: e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown and fallback")
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/smc/af_smc.c