hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
authorJia-Ju Bai <baijiaju1990@163.com>
Tue, 12 Dec 2017 08:49:52 +0000 (16:49 +0800)
committerSasha Levin <alexander.levin@microsoft.com>
Sun, 4 Mar 2018 15:28:28 +0000 (10:28 -0500)
commite23daf3ee076379ca01d2a5756ace3b39f24bd6e
tree1f4db1d668859306f30526564794d54aaaba1d88
parenta089e6cab4b1e5ce15f940c7a008bfde5f408129
hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

[ Upstream commit 6e266610eb6553cfb7e7eb5d11914bd01509c406 ]

The driver may sleep under a spinlock.
The function call path is:
rr_close (acquire the spinlock)
  free_irq --> may sleep

To fix it, free_irq is moved to the place without holding the spinlock.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/net/hippi/rrunner.c