sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race
authorNeilBrown <neilb@suse.com>
Fri, 4 Mar 2016 06:20:13 +0000 (17:20 +1100)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 11 Jul 2016 03:07:16 +0000 (23:07 -0400)
commite28574abf31fbce4ae38606989b3f18e72838b97
tree2c587af1328f901f49c0bd7dd79890cb99db0eba
parent00c0a9f44f68bfe9af73f84cdb93b1695da66b44
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race

[ Upstream commit a6ab1e8126d205238defbb55d23661a3a5c6a0d8 ]

sunrpc_cache_pipe_upcall() can detect a race if CACHE_PENDING is no longer
set.  In this case it aborts the queuing of the upcall.
However it has already taken a new counted reference on "h" and
doesn't "put" it, even though it frees the data structure holding the reference.

So let's delay the "cache_get" until we know we need it.

Fixes: f9e1aedc6c79 ("sunrpc/cache: remove races with queuing an upcall.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/sunrpc/cache.c