cgroup: fix cgroup_subsys_state leak for seq_files
authorTejun Heo <tj@kernel.org>
Wed, 27 Nov 2013 23:16:21 +0000 (18:16 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2013 19:05:55 +0000 (11:05 -0800)
commite6af24fef5c9ed17a25f062b3c22c3df44904dc9
treeee13736ddf7980bab298263e4f08dab8012406ed
parent65d6ec10c7cf2575de2aa9159f8cf43cbc1074fe
cgroup: fix cgroup_subsys_state leak for seq_files

commit e605b36575e896edd8161534550c9ea021b03bc0 upstream.

If a cgroup file implements either read_map() or read_seq_string(),
such file is served using seq_file by overriding file->f_op to
cgroup_seqfile_operations, which also overrides the release method to
single_release() from cgroup_file_release().

Because cgroup_file_open() didn't use to acquire any resources, this
used to be fine, but since f7d58818ba42 ("cgroup: pin
cgroup_subsys_state when opening a cgroupfs file"), cgroup_file_open()
pins the css (cgroup_subsys_state) which is put by
cgroup_file_release().  The patch forgot to update the release path
for seq_files and each open/release cycle leaks a css reference.

Fix it by updating cgroup_file_release() to also handle seq_files and
using it for seq_file release path too.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup.c