fixing infinite OPEN loop in 4.0 stateid recovery
authorOlga Kornievskaia <kolga@netapp.com>
Fri, 15 May 2015 15:45:31 +0000 (11:45 -0400)
committerWilly Tarreau <w@1wt.eu>
Fri, 18 Sep 2015 11:52:09 +0000 (13:52 +0200)
commitea4a2f8c1ea6df6617c21171bea27a89cd3b272c
treed2211f552919e37c44fcd5a5508d622f4c2698ab
parent1edd4c2623a0b84b603ea6c8d345a90100c53e43
fixing infinite OPEN loop in 4.0 stateid recovery

commit e8d975e73e5fa05f983fbf2723120edcf68e0b38 upstream.

Problem: When an operation like WRITE receives a BAD_STATEID, even though
recovery code clears the RECLAIM_NOGRACE recovery flag before recovering
the open state, because of clearing delegation state for the associated
inode, nfs_inode_find_state_and_recover() gets called and it makes the
same state with RECLAIM_NOGRACE flag again. As a results, when we restart
looking over the open states, we end up in the infinite loop instead of
breaking out in the next test of state flags.

Solution: unset the RECLAIM_NOGRACE set because of
calling of nfs_inode_find_state_and_recover() after returning from calling
recover_open() function.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit ef8500b18fc4bb03286a93b6032d56ec7bcbfd15)

Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/nfs/nfs4state.c