irqchip/gic-v3: Fix OF_BAD_ADDR error handling
authorArnd Bergmann <arnd@arndb.de>
Tue, 23 Mar 2021 13:18:35 +0000 (14:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:59:30 +0000 (10:59 +0200)
commitf1dfa84c8f26d6bf372df85837ae0d7fbbc127a9
tree03eed529b7cf36f639c2c7a1c51290f44942fce7
parent191d92a2f6ccc74cf7fc555a001cbe0a2c29b2fb
irqchip/gic-v3: Fix OF_BAD_ADDR error handling

[ Upstream commit 8e13d96670a4c050d4883e6743a9e9858e5cfe10 ]

When building with extra warnings enabled, clang points out a
mistake in the error handling:

drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
                if (mbi_phys_base == OF_BAD_ADDR) {

Truncate the constant to the same type as the variable it gets compared
to, to shut make the check work and void the warning.

Fixes: 505287525c24 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210323131842.2773094-1-arnd@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-gic-v3-mbi.c