btrfs: validate qgroup inherit for SNAP_CREATE_V2 ioctl
authorDan Carpenter <dancarpenter@oracle.com>
Wed, 17 Feb 2021 06:04:34 +0000 (09:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Mar 2021 13:04:59 +0000 (14:04 +0100)
commitf27ce3a7c51a8259dca1cb8ad91cbed7beaee892
tree090527e7edaad2a6cacff317e423e43afe560697
parent78abc4fb9eba8e7c7ac0339027df11404ae3bda2
btrfs: validate qgroup inherit for SNAP_CREATE_V2 ioctl

commit 5011c5a663b9c6d6aff3d394f11049b371199627 upstream.

The problem is we're copying "inherit" from user space but we don't
necessarily know that we're copying enough data for a 64 byte
struct.  Then the next problem is that 'inherit' has a variable size
array at the end, and we have to verify that array is the size we
expected.

Fixes: 6f72c7e20dba ("Btrfs: add qgroup inheritance")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/ioctl.c