dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources
authorzhangqilong <zhangqilong3@huawei.com>
Sat, 19 Mar 2022 02:21:42 +0000 (10:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Apr 2022 11:53:48 +0000 (13:53 +0200)
commitf714abf28f819849d2fd93a4a8db15cff3f8798e
tree6bc51592b77862325dcb4a051f138dd18402c158
parent9bc949a181ba805b76b81d1ae1519af093328b81
dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources

[ Upstream commit 545b2baac89b859180e51215468c05d85ea8465a ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
We fix it:
1) Replacing it with pm_runtime_resume_and_get to keep usage counter
   balanced.
2) Add putting operation before returning error.

Fixes:9135408c3ace4 ("dmaengine: mediatek: Add MediaTek UART APDMA support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20220319022142.142709-1-zhangqilong3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/mediatek/mtk-uart-apdma.c